Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "Code cleanup in serveNamespaceRegistry" #364

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

turetske
Copy link
Collaborator

@turetske turetske commented Nov 9, 2023

Reverts #341 Merge was done incorrectly, only the first of the two commits was merged in. Reverting to attempt to fix it.

@turetske turetske requested a review from haoming29 November 9, 2023 14:27
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will wait for tests to pass before merge.

@turetske turetske merged commit b1aef93 into main Nov 9, 2023
@haoming29 haoming29 deleted the revert-341-fix-namespace-registry-serve.go branch December 18, 2023 15:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants