Reimplimented recursive downloads #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From playing around with things, it seems like the progress bars mostly look okay when the debug log is not activated. When debug is activated, it keeps wanting to print things during the download causing multiple bars for 1 file to be printed. I will create a new issue for this but I think we should implement what we have since it does work correctly. It also seems like it cannot get the correct total for the files when doing this recursively either. Update: made issue #402 for this |
bbockelm
requested changes
Nov 27, 2023
The functionality of recursive downloads has been restored. When specifying with the -r flag and targetting a dir, all the files will be downloaded within that directory. This functionality currently works however the progress bars are a little funky so that still needs fixing.
Made some updates to bearer_auth.go such as adding copywrite statement, removing old commented out code, and changing types to not be exported. Also changed `dirlisthost` to `collections-url` in the header.
joereuss12
force-pushed
the
recursive-downloads-revisit-branch
branch
from
909a26b to
b488c7d
Compare
|
Changed to be a draft because now I can make unit tests for this functionality from the merging of #390 |
|
Marking this as ready for review since the end-to-end tests are currently stalled. See #391 |
bbockelm
approved these changes
Dec 1, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality of recursive downloads has been restored. When specifying with the -r flag and targetting a dir, all the files will be downloaded within that directory. This functionality currently works however the progress bars are a little funky so that still needs fixing.