Git test action updates #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turetske
force-pushed
the
git-test-action-updates
branch
from
b3bb1ed to
7dbc157
Compare
turetske
force-pushed
the
git-test-action-updates
branch
2 times, most recently
from
2b689c4 to
d659c35
Compare
turetske
force-pushed
the
git-test-action-updates
branch
from
498f6ac to
7978f1b
Compare
joereuss12
suggested changes
Nov 20, 2023
There was a problem hiding this comment.
For me when testing, this action is running twice. Once for creating a PR to merge into main and one for doing "push" to create the PR. How I tested was I made a duplicate repo of Pelican, added your changes to this file, then made some change on a different branch and pushed the changes.
It could be just from how everything was set up too so let me know if this is an issue only for me or not. I get something like this though for each of the 3 tests:
Test / test (1.20.x, macos-latest) (pull_request)
Test / test (1.20.x, macos-latest) (push)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the GitHub test workflow to use our linux dev image (so the xrootd e2e test will work). Also updates the image to use a more recent version of nodejs.