Always unmarshall config when /config API is called #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Included Justin as another reviewer for checking Go code |
haoming29
force-pushed
the
config-api-missing-vals
branch
from
b8f6e68 to
c1c4c24
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389
Testing Instructions
Run
directorregistryandorigin, and go to origin's uihttps://localhost:8444/view/config/index.htmlCheck that under Origin subheader, the value of
NamespacePrefixis set to whatever prefix you gave to your origin and registered at registry, say/origin1, because this value is being set afterInitServer()was called.