-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Director UI #466
Director UI #466
Conversation
I will rebase on main once #458 is merged |
- Add the director to the landing page - Add a director main page with cache and origin tables
d82b751
to
f29b5c0
Compare
@CannonLock Do we want to bring back the config page for the director? I'm pretty sure it's still going to be very useful to our director users to see their configs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for most part. One small change is to include WebURL in the column and the other is to include Config page in director's UI
name: "URL", | ||
cellNode: TableCellOverflowLink | ||
} | ||
// webUrl: "Web URL" TODO: Uncomment when the Web URL is populated someday - Cannon Lock 2023/12/06 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is populated if there is a Pelican origin advertised to the director and we should display this column. It is very confusing for now that the OSDF and Pelican origins each have different behaviors in advertisement.
Yeah good call, I will add it. |
@haoming29 I moved the config to the top level rather then create it twice. |
@CannonLock One last thing: it seems like we don't check login status for director's page, is this what we want? I happened to find this when I clicked the config page from the director and I was redirected to login |
@haoming29 I moved the auth redirects to server side. It is a bad user[developer] experience to have them on client side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can fix the server router in a separate ticket.
@haoming29 Fix? Is it doing something incorrectly? |
Everything is good, I meant for the "matching and directing to index.html" thing that Go couldn't do a path rewrite. Not related to the auth change to server. |
Closes #265