Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Director UI #466

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Director UI #466

merged 5 commits into from
Dec 7, 2023

Conversation

CannonLock
Copy link
Contributor

Closes #265

Screenshot 2023-12-06 at 12 44 47 PM (2)

@CannonLock
Copy link
Contributor Author

I will rebase on main once #458 is merged

@CannonLock CannonLock requested review from haoming29 and removed request for haoming29 December 6, 2023 19:04
- Add the director to the landing page
- Add a director main page with cache and origin tables
@haoming29
Copy link
Contributor

@CannonLock Do we want to bring back the config page for the director? I'm pretty sure it's still going to be very useful to our director users to see their configs

Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for most part. One small change is to include WebURL in the column and the other is to include Config page in director's UI

name: "URL",
cellNode: TableCellOverflowLink
}
// webUrl: "Web URL" TODO: Uncomment when the Web URL is populated someday - Cannon Lock 2023/12/06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is populated if there is a Pelican origin advertised to the director and we should display this column. It is very confusing for now that the OSDF and Pelican origins each have different behaviors in advertisement.

@CannonLock
Copy link
Contributor Author

@CannonLock Do we want to bring back the config page for the director? I'm pretty sure it's still going to be very useful to our director users to see their configs

Yeah good call, I will add it.

@CannonLock CannonLock requested a review from haoming29 December 6, 2023 20:34
@CannonLock
Copy link
Contributor Author

@haoming29 I moved the config to the top level rather then create it twice.

@haoming29
Copy link
Contributor

haoming29 commented Dec 6, 2023

@CannonLock One last thing: it seems like we don't check login status for director's page, is this what we want? I happened to find this when I clicked the config page from the director and I was redirected to login

@CannonLock
Copy link
Contributor Author

CannonLock commented Dec 6, 2023

@haoming29 I moved the auth redirects to server side. It is a bad user[developer] experience to have them on client side.

Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can fix the server router in a separate ticket.

@haoming29 haoming29 added this to the v7.3.0 milestone Dec 7, 2023
@CannonLock
Copy link
Contributor Author

LGTM. We can fix the server router in a separate ticket.

@haoming29 Fix? Is it doing something incorrectly?

@haoming29
Copy link
Contributor

LGTM. We can fix the server router in a separate ticket.

@haoming29 Fix? Is it doing something incorrectly?

Everything is good, I meant for the "matching and directing to index.html" thing that Go couldn't do a path rewrite. Not related to the auth change to server.

@CannonLock CannonLock merged commit 06d0afb into PelicanPlatform:main Dec 7, 2023
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web UI for the director
2 participants