Feature/request response headers #1085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A request/response cycle involves two sets of headers. The existing `header` keyword is ambiguous; is that request or response headers? Add the prefix `response_` to the keywords; `header`, `headers` and `push_header` to make it clear these manipulate response headers, while deprecating the existing keywords.
New keyword for accessing request headers, making those as easy to access as response headers. Saves typing `request->headers->header(...)` :D Ref #1039.
Updated the existing t/dsl.t test which tested the `request` keyword to use Plack::Test->create(), then moved to the dsl subdir to add extra subtest for new `reuest_header` keyword.
|
I'm a bit worried about another deprecation notice close to when we're deprecating the old plugin interface. I don't want to overwhelm users. Can we comment those for now? |
|
👍 for delaying deprecation notices especially with the number we're already seeing with P2. |
Timing is everything. With the reworked Plugin codebase due to be merged soon, this is not the time be deprecating existing keywords. Flag the keyword deprecation as a TODO after a period of stability.
|
I concur that there are enough changes happening with the upcoming merge of Plugin2. Deprecation warnings commented out and flagged as a TODO after a period of stability. 😄 |
|
👍 from me. @veryrusty ❤️ |
|
seems legit. |
|
👍 from me as well. Thanks @veryrusty! |
|
Rebased and merged as 431d8d8. Thanks everyone! |
|
@veryrusty++ ! |
xsawyerx
added a commit
that referenced
this pull request
Apr 19, 2016
[ BUG FIXES ]
* GH #1102: Handle multiple '..' in file path utilities.
(Oleg A. Mamontov, Peter Mottram)
* GH #1114: Fix missing prereqs as reported by CPANTS.
(Mohammad S Anwar)
* GH #1128: Shh warning if optional megasplat is not present.
(David Precious)
* GH #1139: Fix incorrect Content-Length header added by AutoPage
handler (Michael Kröll, Russell Jenkins)
* GH #1144: Change tt tags to span in skel (Jason Lewis)
* GH #1046: "no_server_tokens" configuration option doesn't work.
(Sawyer X)
# GH #1155, #1157: Fix megasplat value splitting when there are empty
trailing path segments. (Tatsuhiko Miyagawa, Russell Jenkins)
NOTE: Paths matching a megasplat that end with a '/' will now include
an empty string as the last value. For the route pattern '/foo/**',
the path '/foo/bar', the megasplat gives ['bar'], whereas '/foo/bar/'
now gives ['bar','']. Joining the array of megasplat values will now
always be the string matched against for the megasplit.
[ DOCUMENTATION ]
* GH #1119: Improve the deployment documentation. (Andrew Beverley)
* GH #1123: Document import of utf8 pragma. (Victor Adam)
* GH #1132: Fix spelling mistakes in POD (Gregor Herrmann)
* GH #1134: Fix spelling errors detected by codespell (James McCoy)
* GH #1153: Fix POD rendering error. (Sawyer X)
[ ENHANCEMENTS ]
* GH #1129: engine.logger.* hooks are called around logging a message.
(Russell @veryrusty Jenkins)
* GH #1146: Cleaner display of error context (Vernon Lyon)
* GH #1085: Add consistent keywords for accessing headers;
'request_header' for request, 'response_header', 'response_headers'
and 'push_response_header' for response. (Russell @veryrusty Jenkins)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dose of JFDI for #1039 😉
response_header,response_headers,push_response_header. Existing header keywords deprecated.request_headerwith simple test.