Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allows empty lines in RPP files #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qubitstream
Copy link

  • previously, the parse failed if it encountered an empty line
    due to an IndexError
  • some extensions apparently can add empty lines
  • an example of such a file is in tests/data/with_empty_lines.RPP

 - previously, the parse failed if it encountered an empty line
   due to an IndexError
 - some extensions apparently can add empty lines
 - an example of such a file is in tests/data/with_empty_lines.RPP
@Perlence
Copy link
Owner

Perlence commented Oct 31, 2020

Hello @qubitstream, I'm sorry for the late notice.

Does the extension work OK if you remove the empty line and load the project in REAPER?

@kokounet
Copy link

kokounet commented Oct 2, 2023

The way it's implemented in this PR makes it unable to restore those empty lines when writing the file.

Instead, starts_with_quote and starts_with_pipe (scanner.py:68-75) should just return False if the string is empty, similarly to how the startswith method work in python.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants