fix: Propagate error to sender when asking #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrosPapapa
added a commit
that referenced
this pull request
Nov 1, 2024
* fix: Propagate error to sender when asking (#9) * fix: Propagate error to sender when asking fixes suprnation#25 * refactor: Cleanup AskSpec and scalafmt * refactor: ActorCell$.processMailbox use fold instead of match * feat: Broadcast & Typecheck (#10) * Feature: Scheduled timers (#13) * WIP - Feature: Introduce scheduled timers * Reorganize, cleanup and add copyright * Remove ref update from interceptTimerMsg * Receive msg right away instead of resending * Scala 3 compat * Bring back F covariance * Implement restart and stop unit tests * Bring back explicit type * Rework unit tests using TestKit * Update timers to extend Actor * Add tracking actor utility method * Fix type erasure warning * WIP - Feature: Introduce scheduled timers * Reorganize, cleanup and add copyright * Remove ref update from interceptTimerMsg * Receive msg right away instead of resending * Scala 3 compat * Bring back F covariance * Implement restart and stop unit tests * Bring back explicit type * Rework unit tests using TestKit * Update timers to extend Actor * Add tracking actor utility method * Fix type erasure warning --------- Co-authored-by: jeronimo <jeronimo@suprnation.com> * feature: Switched to .as instead of .map (+2 squashed commits) Squashed commits: [496b4d6] feature: Switched to .map instead of .flatMap [769c4ea] feature: Fixed issue with deadletter mailbox showing that it's open. Added expectMsgPF and expectTerminated TestKit methods * feature: Added receiveWhile to the TestKit and refactored the TestKitSpec * feature: Added the ability to ignore schedules in the waitForIdle helper method. * style: scalafmt * fix: Scala 3 does not like the Timer type when matching * docs: missing headers --------- Co-authored-by: Jeronimo Carlos <jeronimo.carlos@ing.austral.edu.ar> Co-authored-by: jeronimo <jeronimo@suprnation.com> Co-authored-by: Massimo Saliba <massimo@suprnation.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes suprnation#25
Lets ActorCell$.invoke propagate exceptions to processMailbox and then through the Deferred back to the sender.
The Deferred has to be an Either as a channel for the exception.
Added a unit test for this as well.
Note that an exception in the receiver will now make both the receiver and the sender fail (as opposed to only the receiver).