Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix build - issue #3 #4

Merged
merged 4 commits into from
Jun 6, 2017
Merged

fix build - issue #3 #4

merged 4 commits into from
Jun 6, 2017

Conversation

umens
Copy link
Contributor

@umens umens commented Jun 5, 2017

PR based on @guidux comments on the issue #3

guidux
guidux reviewed Jun 5, 2017
View reviewed changes
Copy link

@guidux guidux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. The only small doubt is about angular 2.4.4 perhaps it is better to have ~2.4.4 or even better ^2.4.4 . Even though, it needs to be tested for more people.

@PhilippStein
Copy link
Owner

@umens Thanks for your pull request, I will test it in the next view days. But @guidux is right about the dependencies. Because of angular 4 and upcoming the angular dependency must be ">=2.4.4", see #2

@umens
Copy link
Contributor Author

umens commented Jun 5, 2017 •
edited
Loading

I just updated the dependencies to match this

@PhilippStein PhilippStein merged commit 416902c into PhilippStein:master Jun 6, 2017
@PhilippStein PhilippStein mentioned this pull request Jun 6, 2017
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@guidux guidux guidux left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umens @PhilippStein @guidux