Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add improvements for airstrike flare visuals #1565

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Starkku
Copy link
Contributor

@Starkku Starkku commented Mar 7, 2025

Bugfixes

  • Fixed an issue where airstrike flare line drawn to target at lower elevation would clip (by Starkku)

Airstrike flare customizations

  • It is now possible to customize color of airstrike flare tint on target on the TechnoType calling in the airstrike as well as customize the color of the line drawn to target.
    • LaserTargetColor can be used to set the index of color from [ColorAdd] defaults to [AudioVisual] -> LaserTargetColor.
    • AirstrikeLineColor sets the color of the line and dot drawn from firer to target, defaults to [AudioVisual] -> AirstrikeLineColor.

In rulesmd.ini:

[AudioVisual]
AirstrikeLineColor=255,0,0  ; integer - Red,Green,Blue

[SOMETECHNO]                ; TechnoType
LaserTargetColor=           ; integer - [ColorAdd] index
AirstrikeLineColor=         ; integer - Red,Green,Blue

@Starkku Starkku force-pushed the feature/airstrike-visuals branch from e7ebdf5 to 226ae94 Compare March 7, 2025 16:31
@TaranDahl TaranDahl added ❓New feature ❓Vanilla bug Vanilla game bugs that are requested to be fixed ⚙️T1 T1 maintainer review is sufficient labels Mar 9, 2025
@Starkku Starkku force-pushed the feature/airstrike-visuals branch 2 times, most recently from 2a59b6a to 2a013f5 Compare March 28, 2025 11:16
Copy link

github-actions bot commented Mar 28, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@mevitar
Copy link

mevitar commented Apr 2, 2025

The colors seem to work fine, but then the game crashes like 1 second after the flare effect is created. The crash doesn't happen with other builds.

@Starkku Starkku force-pushed the feature/airstrike-visuals branch from 2a013f5 to 55437f9 Compare April 11, 2025 20:45
@Starkku
Copy link
Contributor Author

Starkku commented Apr 11, 2025

The colors seem to work fine, but then the game crashes like 1 second after the flare effect is created. The crash doesn't happen with other builds.

I need more information on this such as the crash logs as I cannot reproduce this.

@mevitar
Copy link

mevitar commented Apr 11, 2025

I need more information on this such as the crash logs as I cannot reproduce this.

Well, no wonder, because it doesn't crash anymore. :P

@mevitar
Copy link

mevitar commented Apr 11, 2025

Everything seems to be working fine now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
❓New feature ⚙️T1 T1 maintainer review is sufficient Tested ❓Vanilla bug Vanilla game bugs that are requested to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants