Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Unit test assertions failure in ScsiCdTest_ModeSelect_Test::TestBody #1418

Closed
rdmark opened this issue Jan 16, 2024 · 4 comments
Closed

Unit test assertions failure in ScsiCdTest_ModeSelect_Test::TestBody #1418

rdmark opened this issue Jan 16, 2024 · 4 comments

Comments

@rdmark
Copy link
Member

rdmark commented Jan 16, 2024

When run in debug mode, there is an assertion failure in ScsiCdTest_ModeSelect_Test::TestBody. This is only triggered when unit tests are compiled with the DEBUG=1 flag.

Uwe spotted and reported this in #1415 -- see that ticket for the stack trace with symbols.
@rdmark
Copy link
Member Author

rdmark commented Jan 16, 2024

@kkaempf I think this failed assertion was introduced with #1406

Would you be able to have a look?

FWIW I'm proposing we enable DEBUG for unit tests in the CI workflow as well, to catch these earlier in the future: #1417

@kkaempf
Copy link
Contributor

kkaempf commented Jan 16, 2024

I can't reproduce a test crash on my issue-1410 branch (forked from ad5eae9) when compiled with DEBUG=1 🤷🏻‍♂️

@kkaempf
Copy link
Contributor

kkaempf commented Jan 16, 2024

I'll rebase and test again ...

@kkaempf
Copy link
Contributor

kkaempf commented Jan 16, 2024

Rebased onto 7a986c8 I get a crash

kkaempf added a commit to kkaempf/piscsi that referenced this issue Jan 17, 2024
@kkaempf
DiskCache needs a size
dbc986b 
otherwise its constructor assertion (block > 0) will fail.

Fixes PiSCSI#1418

Signed-off-by: Klaus Kämpf <kkaempf@gmail.com>
This was referenced Jan 17, 2024
Closed
Merged
rdmark pushed a commit that referenced this issue Jan 18, 2024
@kkaempf @rdmark
DiskCache needs a size
7cc8df2 
otherwise its constructor assertion (block > 0) will fail.

Fixes #1418

Signed-off-by: Klaus Kämpf <kkaempf@gmail.com>
@rdmark rdmark closed this as completed Jan 19, 2024
kkaempf added a commit to kkaempf/piscsi that referenced this issue Apr 2, 2024
@kkaempf
DiskCache needs a size
7addade 
otherwise its constructor assertion (block > 0) will fail.

Fixes PiSCSI#1418

Signed-off-by: Klaus Kämpf <kkaempf@gmail.com>
rdmark pushed a commit that referenced this issue May 1, 2024
@kkaempf @rdmark
DiskCache needs a size
70dfade 
otherwise its constructor assertion (block > 0) will fail.

Fixes #1418

Signed-off-by: Klaus Kämpf <kkaempf@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure DiskCache constructor is called with a blocks count > 0 kkaempf/piscsi
2 participants
@kkaempf @rdmark