Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

std::move() improvements suggested by clang-tidy #215

Closed
AndyZe opened this issue Aug 11, 2024 · 0 comments · Fixed by #228
Closed

std::move() improvements suggested by clang-tidy #215

AndyZe opened this issue Aug 11, 2024 · 0 comments · Fixed by #228

Comments

@AndyZe
Copy link

AndyZe commented Aug 11, 2024

/home/andy/ws_moveit/build/moveit_servo/moveit_servo_lib_parameters/include/moveit_servo_lib_parameters.hpp:167:17: warning: parameter 'logger' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
   17 |       logger_ = logger;
      |                 ^     
      |                 std::move( )
/home/andy/ws_moveit/build/moveit_servo/moveit_servo_lib_parameters/include/moveit_servo_lib_parameters.hpp:988:19: warning: parameter 'updated_params' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
  988 |         params_ = updated_params;
      |                   ^             
      |                   std::move(    )
      ```
@AndyZe AndyZe changed the title Improvements suggested by clang-tidy std::move() improvements suggested by clang-tidy Aug 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
1 participant