Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Separation between the camera component and data provider #289

Open
wants to merge 1 commit into
base: dev_extracted_libraries
Choose a base branch
from

Conversation

elad-bar
Copy link

  • Add vacuum manager to handle all the logic
  • Camera component will use the latest state of the vacuum manager
  • Map status to log messages - every time status is being changed, it will be logged accordingly, no need to call logger
  • Map device to handlers instead of IF statement

@PiotrMachowski
Copy link
Owner

It looks quite nice. I thought about using built-in coordinator though:
https://github.com/home-assistant/core/blob/dev/homeassistant/helpers/update_coordinator.py

@elad-bar
Copy link
Author

I wanted it to be simple as possible so didn't add new elements just separation and cleanup, but correct, next step is to wrap it as coordinator

@PiotrMachowski
Copy link
Owner

That's an easy change :) I will take a look at it 👍 thank you!

@PiotrMachowski PiotrMachowski changed the base branch from master to dev May 24, 2022 15:28
@elad-bar
Copy link
Author

elad-bar commented Jan 5, 2023

@PiotrMachowski any updates about that PR?

thanks

@PiotrMachowski
Copy link
Owner

PiotrMachowski commented Jan 5, 2023

@elad-bar I plan to make a lot of maintenance on all my repos soon, sorry for long wait, I have a lot of other repos to maintain

@PiotrMachowski PiotrMachowski changed the base branch from dev to dev_extracted_libraries January 3, 2025 06:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants