-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[BUG] Airtable triggers are getting OOM #15990
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Hello everyone, I have tested this PR and there're some test cases failed or needed improvement. Please check the test report below for more information |
Hi @vunguyenhung I've just pushed some changes where I'm not using the |
Hey @jcortes, I also couldn't reproduce either, though I think it's best to include the maxRecords to our API calls, maybe we can hard code it to 50, then we can add the info box to inform user that maximum the source will emit 50 events each, new runs will emit remaining events |
Hello everyone, I have tested this PR and there're some test cases failed or needed improvement. Please check the test report below for more information |
@vunguyenhung please try with latest push, I saw your report and you tested with the one before the latest sorry for that. |
Hi everyone, all test cases are passed! Ready for release! Test report |
Describe the bug
Depending on the number of records (and its contents) being fetched in the Airtable triggers, it can get an OOM error (for example > 150).
This request is to add an optional prop:
to the triggers, and it translates to the param
maxRecords
in the Airtable API:Not sure if this should be added to the base common file or to each individual trigger code.
Additional context
Reported by a user
The text was updated successfully, but these errors were encountered: