Skip to content

[BUG] Airtable triggers are getting OOM #15990

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
andrewjschuang opened this issue Mar 20, 2025 · 6 comments · Fixed by #16044
Closed

[BUG] Airtable triggers are getting OOM #15990

andrewjschuang opened this issue Mar 20, 2025 · 6 comments · Fixed by #16044
Assignees
Labels
bug Something isn't working triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@andrewjschuang
Copy link
Collaborator

Describe the bug
Depending on the number of records (and its contents) being fetched in the Airtable triggers, it can get an OOM error (for example > 150).

This request is to add an optional prop:

    maxRecordsPerExecution: {
      type: "integer",
      label: "Maximum Records Per Execution",
      description: "Set a maximum number of records to fetch per execution if your trigger is failing",
      optional: true,
    }

to the triggers, and it translates to the param maxRecords in the Airtable API:

    const params = {
      ...,
      maxRecords: this.maxRecordsPerExecution,
    }

Not sure if this should be added to the base common file or to each individual trigger code.

Additional context
Reported by a user

@andrewjschuang andrewjschuang added the bug Something isn't working label Mar 20, 2025
@jcortes jcortes self-assigned this Mar 25, 2025
@jcortes jcortes moved this from Prioritized to Doing in Component (Source and Action) Backlog Mar 25, 2025
@jcortes jcortes moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Mar 25, 2025
@michelle0927 michelle0927 moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Mar 25, 2025
@vunguyenhung vunguyenhung added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Mar 26, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Mar 26, 2025
@vunguyenhung vunguyenhung moved this from In QA to Changes Required in Component (Source and Action) Backlog Mar 26, 2025
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/BUG-Airtable-triggers-are-getting-OOM-1c1bf548bb5e81f7a4d4e04b5b249eed

@jcortes
Copy link
Collaborator

jcortes commented Mar 27, 2025

Hi @vunguyenhung I've just pushed some changes where I'm not using the maxRecords prop. I've tested them and seems like I couldn't reproduce the OOM error so can you please give it a try if with this change the error got fixed. Thanks!

@jcortes jcortes moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Mar 27, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Mar 27, 2025
@vunguyenhung
Copy link
Collaborator

Hey @jcortes, I also couldn't reproduce either, though I think it's best to include the maxRecords to our API calls, maybe we can hard code it to 50, then we can add the info box to inform user that maximum the source will emit 50 events each, new runs will emit remaining events

@vunguyenhung vunguyenhung moved this from In QA to Changes Required in Component (Source and Action) Backlog Mar 27, 2025
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/BUG-Airtable-triggers-are-getting-OOM-1c1bf548bb5e81f7a4d4e04b5b249eed

@jcortes
Copy link
Collaborator

jcortes commented Mar 27, 2025

@vunguyenhung please try with latest push, I saw your report and you tested with the one before the latest sorry for that.
On the other hand about your suggestion on maxRecords I think in this case doesn't apply because it will only response with those number of records potentially leaving out records as you pointed out in a previous QA test

Image

@vunguyenhung vunguyenhung moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Mar 27, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to Ready for Release in Component (Source and Action) Backlog Mar 27, 2025
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/BUG-Airtable-triggers-are-getting-OOM-1c1bf548bb5e81f7a4d4e04b5b249eed

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working triaged For maintainers: This issue has been triaged by a Pipedream employee
Development

Successfully merging a pull request may close this issue.

3 participants