Skip to content

[BUG] Airtable triggers are getting OOM #16044

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

jcortes
Copy link
Collaborator

@jcortes jcortes commented Mar 25, 2025

WHY

Resolves #15990

Summary by CodeRabbit

  • Chores
    • Updated version numbers to ensure the integration remains current.
  • New Features
    • Introduced a new method for improved record fetching based on last modified time.
  • Refactor
    • Streamlined how parameters are configured for API calls, enhancing consistency and control over data retrieval.
    • Improved logic for emitting new and modified records, including metadata and timestamps.

@jcortes jcortes self-assigned this Mar 25, 2025
Copy link

vercel bot commented Mar 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2025 11:58am
pipedream-docs ⬜️ Ignored (Inspect) Mar 27, 2025 11:58am
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Mar 27, 2025 11:58am

Copy link
Contributor

coderabbitai bot commented Mar 25, 2025

Walkthrough

This PR updates several parts of the Airtable OAuth integration. The package version in the component’s package.json has been bumped, and new functionality has been added in the common source with methods for fetching records. The changes also refactor several trigger files to utilize the new helper method for constructing API parameters, thereby centralizing parameter creation.

Changes

File(s) Change Summary
components/airtable_oauth/package.json Updated version from "0.4.1" to "0.4.2".
components/airtable_oauth/sources/common/common.mjs Added method getListRecordsParams(params) for enhanced record fetching.
components/airtable_oauth/sources/new-modified-or-deleted-records/...mjs,
components/airtable_oauth/sources/new-or-modified-records-in-view/...mjs,
components/airtable_oauth/sources/new-records-in-view/...mjs
Bumped versions and refactored run methods to use getListRecordsParams for constructing parameters instead of manual definitions.

Assessment against linked issues

Objective Addressed Explanation
Add optional maxRecords per execution property for limiting fetched records in triggers [#15990] The implementation of the maxRecordsPerExecution property is not included in this PR.

Possibly related PRs

  • New Components - what_are_those #15207: The changes in the main PR, specifically the addition of the getListRecordsParams method, are related to the modifications in the run methods of the retrieved PR, which now utilize this method for constructing parameters.
  • Fix Airtable URL field asking for object input #14835: The changes in the main PR, which involve adding a new method for constructing parameters in Airtable API calls, are related to the retrieved PR that addresses the prop type for the URL field type, as both involve modifications to how parameters are handled in the Airtable component.

Suggested reviewers

  • vunguyenhung

Poem

I'm a rabbit in the code burrow,
Hopping through changes with a happy glow,
New methods and props guide my way,
Keeping records in check all day,
Carrots and code make a perfect pair,
Celebrating updates with a joyful flair!
🐇💻

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/airtable_oauth/sources/common/common.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

components/airtable_oauth/sources/new-or-modified-records-in-view/new-or-modified-records-in-view.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

components/airtable_oauth/sources/new-modified-or-deleted-records/new-modified-or-deleted-records.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

  • 1 others

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f98de68 and 6caa8ec.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • components/airtable_oauth/package.json (1 hunks)
  • components/airtable_oauth/sources/common/common.mjs (1 hunks)
  • components/airtable_oauth/sources/new-modified-or-deleted-records/new-modified-or-deleted-records.mjs (3 hunks)
  • components/airtable_oauth/sources/new-or-modified-records-in-view/new-or-modified-records-in-view.mjs (3 hunks)
  • components/airtable_oauth/sources/new-records-in-view/new-records-in-view.mjs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • components/airtable_oauth/sources/common/common.mjs
  • components/airtable_oauth/package.json
  • components/airtable_oauth/sources/new-records-in-view/new-records-in-view.mjs
  • components/airtable_oauth/sources/new-or-modified-records-in-view/new-or-modified-records-in-view.mjs
  • components/airtable_oauth/sources/new-modified-or-deleted-records/new-modified-or-deleted-records.mjs
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: pnpm publish
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Publish TypeScript components

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

michelle0927
michelle0927 previously approved these changes Mar 25, 2025
Copy link
Collaborator

@michelle0927 michelle0927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcortes jcortes force-pushed the fix-airtable-triggers-oom-error branch 2 times, most recently from b34b40d to f98de68 Compare March 27, 2025 00:16
@jcortes jcortes force-pushed the fix-airtable-triggers-oom-error branch from f98de68 to 6caa8ec Compare March 27, 2025 11:58
@jcortes
Copy link
Collaborator Author

jcortes commented Mar 27, 2025

/approve

@jcortes jcortes merged commit 1e4db9a into master Mar 27, 2025
11 checks passed
@jcortes jcortes deleted the fix-airtable-triggers-oom-error branch March 27, 2025 14:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Airtable triggers are getting OOM
2 participants