Make SdfPathTable::_EraseSubtreeAndSiblings non-recursive #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re is no risk of running out of stack space even with an incredibly large number of siblings.
|
Filed as internal issue #USD-6012 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the SdfPathTable::_EraseSubtreeAndSiblings function non-recursive, so there is no risk of running out of stack space even with an incredibly large number of siblings.
Description of Change(s)
Replaced a recursive implementation of iteration with a non-recursive iteration. The resulting ordering of calls to _EraseFromTable is reversed (first to last instead of last to first), but looking at _EraseFromTable I don't think this should make any difference.
Fixes Issue(s)