Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace boost hash usage with TfHash in pxr/usd/ar #2185

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Jan 20, 2023

Description of Change(s)

To remove the dependency of pxr/usd/ar on boost's hashing functions

  • Test coverage of __hash__ has been added for ArDefaultResolverContext
  • Replaces usage of boost::hash_combine with TfHash's default hashing of vectors and strings

Fixes Issue(s)

-#2172 (more PRs forthcoming)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc force-pushed the arhash branch 2 times, most recently from c35c37b to a78ce1c Compare January 26, 2023 22:49
@sunyab
Copy link
Contributor

sunyab commented Jan 27, 2023

Filed as internal issue #USD-7905

@pixar-oss pixar-oss merged commit 7e6952f into PixarAnimationStudios:dev Mar 2, 2023
@nvmkuruc nvmkuruc deleted the arhash branch March 2, 2023 19:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants