APPLE: Fix for PySide 6.5.0 initialization order. #2392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-8255 |
creijon
force-pushed
the
jon/dev/pyside_6_5_0_fix
branch
from
2dce08d to
3e789ba
Compare
creijon
force-pushed
the
jon/dev/pyside_6_5_0_fix
branch
2 times, most recently
from
5502e93 to
cd09764
Compare
creijon
force-pushed
the
jon/dev/pyside_6_5_0_fix
branch
from
cd09764 to
c4b6581
Compare
creijon
force-pushed
the
jon/dev/pyside_6_5_0_fix
branch
2 times, most recently
from
33f7177 to
c4b6581
Compare
creijon
force-pushed
the
jon/dev/pyside_6_5_0_fix
branch
from
c4b6581 to
d331ed6
Compare
pixar-oss
pushed a commit
that referenced
this pull request
Jun 21, 2023
The recent change in Pyside 6.5.0 here: pyside/pyside-setup@e809546 Introduced correct multiple inheritance through the use of the `super()` Method Resolution Order. I checked the MRO of ViewSettingsDataModel, which was: ``` <class 'pxr.Usdviewq.viewSettingsDataModel.ViewSettingsDataModel'> <class 'PySide6.QtCore.QObject'> <class 'Shiboken.Object'> <class 'pxr.Usdviewq.settings.StateSource'> <class 'object'> ``` This meant that the `StateSource` object wasn't being initialised correctly. With this change the MRO is: ``` <class 'pxr.Usdviewq.viewSettingsDataModel.ViewSettingsDataModel'> <class 'pxr.Usdviewq.settings.StateSource'> <class 'PySide6.QtCore.QObject'> <class 'Shiboken.Object'> <class 'object'> ``` And the initialisation works correctly. Checked with PySide 6.5.0 and 6.4.3 Contribution: Apple Fixes #2392 (Internal change: 2281902)
|
This PR was merged into the |
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The recent change in Pyside 6.5.0 here:
pyside/pyside-setup@e809546
Introduced correct multiple inheritance through the use of the
super()Method Resolution Order. I checked the MRO of ViewSettingsDataModel, which was:This meant that the
StateSourceobject wasn't being initialised correctly. With this change the MRO is:And the initialisation works correctly. Checked with PySide 6.5.0 and 6.4.3
Fixes Issue(s)