Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace boost::totally_ordered with explicit operator overloads for SdfHandle #2510

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

nvmkuruc
Copy link
Collaborator

Description of Change(s)

  • Add explicit implementations of operator{<=,>,>=,!=} to SdfHandle when the template parameters match. This mirrors the current behavior inherited from boost::totally_ordered even though operator== and operator< are parameterized to be more general.
  • Add doxygen comments so operator!= references operator== and operator{<=,>,>=} reference operator<

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc force-pushed the sdfhandlesordered branch from 63acb0b to fe187d8 Compare June 27, 2023 17:16
@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-8450

@nvmkuruc nvmkuruc force-pushed the sdfhandlesordered branch from a9a940c to fbd4558 Compare July 3, 2023 16:32
@pixar-oss pixar-oss merged commit 999cb87 into PixarAnimationStudios:dev Jul 27, 2023
@nvmkuruc nvmkuruc deleted the sdfhandlesordered branch December 29, 2023 03:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants