Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Material-X: flatten filenames upon read #974 #2660

Merged

Conversation

Derek-Nvidia
Copy link
Contributor

@Derek-Nvidia Derek-Nvidia commented Sep 7, 2023

Description of Change(s)

  1. Call mx::flattenFilenames() anytime a mx::read* function is called. This results in a document in which all of the 'fileprefix' attributes have been fully resolved and prepended to any inputs of type 'filename'
  2. Add test_ExpandFilePrefix to TestFileFormat to test fileprefix resolution at various scopes in the MaterialX document.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

…ia the StringResolver.

2. Add test_ExpandFilePrefix to TestFileFormat to test fileprefix resolution at various scopes in the MaterialX document.
@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-8666

@Derek-Nvidia Derek-Nvidia changed the title Add support for MaterialX StringResovler #974 Material-X: flatten filenames upon read #974 Oct 18, 2023
@pixar-oss pixar-oss merged commit 973b0f9 into PixarAnimationStudios:dev Nov 1, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants