Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Specify invalid UTF-8 characters in URI scheme registration errors #2859

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Dec 11, 2023

Description of Change(s)

(Depends on #2858 and #2889)

#2814 observed that a stray - from a diff ended up in the error reporting code for scheme validation. The conditional partitioning ASCII and UTF-8 code paths does not work, and the broken ASCII code path appears to never be exercised.

Now that #2858 has provided a class for encoding code points into strings, the same code path can be used for both.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-9070

@nvmkuruc nvmkuruc force-pushed the arutf branch 2 times, most recently from 925525c to 6102764 Compare December 16, 2023 00:45
@nvmkuruc nvmkuruc force-pushed the arutf branch 3 times, most recently from 08c796a to 4d18d2d Compare December 26, 2023 18:32
@nvmkuruc nvmkuruc force-pushed the arutf branch 2 times, most recently from 8524027 to 9f7fa35 Compare January 3, 2024 00:17
@sunyab sunyab added the usd-utf8-identifiers Issues/PRs for Unicode Identifiers in USD proposal label Jan 11, 2024
@pixar-oss pixar-oss merged commit 32c1a99 into PixarAnimationStudios:dev Feb 5, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
usd-utf8-identifiers Issues/PRs for Unicode Identifiers in USD proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants