Apple: Include the USD patch version in the namespace #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
USD has set its internal namespace to include the major (always 0), and minor (year) versions, but hasn't thus far included the patch version. Since USD doesn't follow semver, the patch version is actually quite important, as there may be ABI changes between USD versions within the same year. Including the patch version will improve the intended nature of the namespacing IMHO. For example, 24.3 and 24.11 may be quite dramatically different in terms of ABI and API, but include the same namespace
|
Filed as internal issue #USD-9850 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This seems like a good idea. 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
USD has set its internal namespace to include the major (always 0), and minor (year) versions, but hasn't thus far included the patch version.
Since USD doesn't follow semver, the patch version is actually quite important, as there may be ABI changes between USD versions within the same year.
Including the patch version will improve the intended nature of the namespacing IMHO. For example, 24.3 and 24.11 may be quite dramatically different in terms of ABI and API, but include the same namespace