Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: prevent delete operation from deleting all contents #68

Merged

Conversation

tinect
Copy link
Contributor

@tinect tinect commented Dec 23, 2023

Closes #67

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb44910) 74.90% compared to head (a25e59f) 75.09%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #68      +/-   ##
============================================
+ Coverage     74.90%   75.09%   +0.19%     
- Complexity       94       96       +2     
============================================
  Files             3        3              
  Lines           251      253       +2     
============================================
+ Hits            188      190       +2     
  Misses           63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sifex sifex merged commit 0b0fbf8 into PlatformCommunity:master Jan 28, 2024
5 checks passed
@sifex
Copy link
Collaborator

sifex commented Jan 29, 2024

Published in v3.3.3

@tinect tinect deleted the feat/preventDirectoryDeletion branch January 29, 2024 16:29
@tinect
Copy link
Contributor Author

tinect commented Jan 29, 2024

Thank you :-)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete without any input should throw an error
2 participants