Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Plume front arm support #402

Merged
merged 7 commits into from
Dec 31, 2018
Merged

Plume front arm support #402

merged 7 commits into from
Dec 31, 2018

Conversation

mcrosson
Copy link
Contributor

@mcrosson mcrosson commented Dec 31, 2018

This PR addresses #394 and #400

Changes

  • Update Dockerfile to add necessary lld dependency on arm platforms via a helper script
  • Run the build/install of plume-front with the necessary linker=lld option on arm platforms via a helper script
  • Add rust-toolchain to Docker container along with Cargo files to ensure the right rust toolchain is selected for later steps

Builds Tested On

  • x86-64
  • arm64 (aarch64)
  • arm32 (armv7l)

Noteworthy items

  • The rust wasm packages do NOT include rustc-lld for arm
  • The lld binaries published by llvm.org will NOT build plume-front with linker=lld rust args
  • lld built from sources (what this patch does) on arm DOES build plume-front with linker=lld rust args

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   27.88%   27.88%           
=======================================
  Files          63       63           
  Lines        7252     7252           
=======================================
  Hits         2022     2022           
  Misses       5230     5230

@trinity-1686a
Copy link
Contributor

I'd prefer plume-front.sh and wasm-deps.sh to be put in the script folder, else it seems all good

trinity-1686a
trinity-1686a previously approved these changes Dec 31, 2018
Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds Tested On

  • x86-64
  • arm64 (aarch64)
  • arm32 (armv7l)

Are you sure you don't have uncommitted changes? Compilation failed for me with x86-64, with the issue about scoping lint being experimental

@trinity-1686a trinity-1686a merged commit dfa89e2 into Plume-org:master Dec 31, 2018
@mcrosson mcrosson deleted the plume-front-arm-support branch December 31, 2018 17:46
@vielmetti
Copy link

The lld binaries published by llvm.org will NOT build plume-front with linker=lld rust args

@mcrosson do you recall what's missing with the llvm distributed lld binaries? I wonder if that's something that might be fixed upstream.

@mcrosson
Copy link
Contributor Author

@vielmetti IIRC the Rust packaging does not include arm32 or 64 as tier 1 for lld-wasm. I think it's on the WASM side? My memory is mildly hazy, there were a lot of tickets that I read and I'm still not familiar with the rust ecosystem.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants