-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Plume front arm support #402
Plume front arm support #402
Conversation
…y dependencies on arm (x86 left untouched inside the script)
…uilds to improve layer caching on subsequent docker builds
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
=======================================
Coverage 27.88% 27.88%
=======================================
Files 63 63
Lines 7252 7252
=======================================
Hits 2022 2022
Misses 5230 5230 |
I'd prefer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds Tested On
- x86-64
- arm64 (aarch64)
- arm32 (armv7l)
Are you sure you don't have uncommitted changes? Compilation failed for me with x86-64, with the issue about scoping lint being experimental
@mcrosson do you recall what's missing with the llvm distributed lld binaries? I wonder if that's something that might be fixed upstream. |
@vielmetti IIRC the Rust packaging does not include arm32 or 64 as tier 1 for lld-wasm. I think it's on the WASM side? My memory is mildly hazy, there were a lot of tickets that I read and I'm still not familiar with the rust ecosystem. |
This PR addresses #394 and #400
Changes
Builds Tested On
Noteworthy items