Permettre de taguer les imports nécessitant des compléments/correctifs #253

mvergez · 2021-12-20T16:07:36Z

Closes #230

Replaced all checks for gn_is_valid = True etc. to an empty/not empty gn_invalid_reason. So that we can get rid of gn_is_valid

Remove everything that created and populated the gn_is_valid column Now there is no more gn_is_valid column and all the validation is done with gn_invalid_reason

To load and set the fix attributes which are the need_fix bool and fix_comment string. Added a "rights" function to check that the user has the rights to CRUD the import

Add get in getValidData Add set in a new route called setFixData

Need to use update on the query. Improved also the get functions

To say that the import needs to be fixed and to add a comment The update button calls the API to update the fix status of the import Add responsive style

That, for now, checks if the user has rights to update this import

So that it can reused in the import report!

So that it does not get buggy in the import report (see next commits)

Do this in the step4 component and not in the need-fix component since it is reused!

So that the user can change the state of the import directly in the report

Set/Get enables when importId is set to get the permissions automatically, otherwise with concurrency there can be misses Add ng_container with ngIf on fix for kind of the same reasons

Instead of errors, now filter on "need_fix". Replaced the Warning Sign on need_fix imports

Changed icon so that is does not interfere with the one in the import list Changed the title for it to be shorter et clearer

mvergez · 2021-12-21T16:43:44Z

Ce qui a été fait

Backend/db :

Suppression de la colonne gn_is_valid dans les tables relatifs aux imports (créés automatiquement). Tout est maintenant basé sur la colonne gn_invalid_reason. La ligne sera donc valide s'il n'y a pas de gn_invalid_reason.
Ajout de 2 colonnes dans la table t_imports : need_fix et fix_comment, permet de décider si un import nécessite une correction. L'utilisateur est libre d'ajouter un commentaire
Ajout d'un script SQL de migration (qui ajoute ces 2 colonnes)
Récupération de ces valeurs dans la route getValidData, cette route a été choisie car déjà utilisée dans l'étape 4 et le rapport d'import.
Ajout d'une route PUT pour changer ces valeurs (need_fix et fix_comment) : setValidData. Seul l'utilisateur ayant un droit U peut appeler cette route.
Ajout d'une route permissions pour savoir si l'utilisateur peut Update l'import (je crois que cela n'existait pas). Cela permettra de gérer les droits sur la modification de ces champs à l'étape 4 et dans le rapport d'import

Frontend :

Ajout d'un service gérant les permissions.
Ajout de la nouvelle route setValidData dans le DataService.
Ajout d'un composant pour la gestion des valeurs need_fix et fix_comment composé d'un slider toggle, d'un champ texte et d'un bouton "Mettre à jour".
Ajout de ce composant dans le composant de l'étape 4 et dans celui du rapport d'import.
Modification de la liste des imports :
- La checkbox pour filtrer sur les rapports en erreur filtre maintenant sur les rapports nécessitant des corrections.
- L'icone "Danger" apparait uniquement si le rapport nécessite des corrections.

Quelques captures (mon thème GeoNature est bleu)

Etape 4 :
Rapport d'import :

Liste d'imports :

…nto feat/import-tag

And add all migrations

Maxime Vergez added 20 commits December 20, 2021 15:54

feat(gn_is_valid): Replace all checks

630d961

Replaced all checks for gn_is_valid = True etc. to an empty/not empty gn_invalid_reason. So that we can get rid of gn_is_valid

feat(gn_is_valid): remove all remaining refs

409124a

Remove everything that created and populated the gn_is_valid column Now there is no more gn_is_valid column and all the validation is done with gn_invalid_reason

feat(model): add need_fix and fix_comment columns

88853f5

feat(api): Set need_fix when import has errors

5b4354a

feat(need_fix): add query helpes and rights

7c5fc12

To load and set the fix attributes which are the need_fix bool and fix_comment string. Added a "rights" function to check that the user has the rights to CRUD the import

feat(routes): added get/set fix data

c656e92

Add get in getValidData Add set in a new route called setFixData

fix(query): updating fix attr now works

88f7ea5

Need to use update on the query. Improved also the get functions

feat(service): add call to /setFix route

c8b5d7f

feat(step4): add slidetoggle + text input + btn

f626fe6

To say that the import needs to be fixed and to add a comment The update button calls the API to update the fix status of the import Add responsive style

feat(api): add permission route

aec3273

That, for now, checks if the user has rights to update this import

feat(service): add the permission service

8cb3b58

refact(need_fix): create a need-fix component

1eac592

So that it can reused in the import report!

fix(need-fix): set the permission afterViewInit

2320ca0

So that it does not get buggy in the import report (see next commits)

style(step4): reput vertical line in step4

e11d042

Do this in the step4 component and not in the need-fix component since it is reused!

feat(report): add need-fix component to report

eeef7a5

So that the user can change the state of the import directly in the report

feat(need-fix): add set/get for importId + ngIf

10b1885

Set/Get enables when importId is set to get the permissions automatically, otherwise with concurrency there can be misses Add ng_container with ngIf on fix for kind of the same reasons

feat(list): now filter on need_fix

52160a9

Instead of errors, now filter on "need_fix". Replaced the Warning Sign on need_fix imports

chore(need-fix): add new line on html

6a364b2

style(report): changed icon and fix title

af72927

Changed icon so that is does not interfere with the one in the import list Changed the title for it to be shorter et clearer

style(list): Change titles

9a4da99

mvergez marked this pull request as ready for review December 21, 2021 16:43

Maxime Vergez added 3 commits December 30, 2021 12:01

chore(sql): changed migration script name

c6e6deb

Merge branch 'project-FLA_NS' of github.com:PnX-SI/gn_module_import i…

6e4c920

…nto feat/import-tag

feat(sql): changed name of migration script

9abbb27

And add all migrations

DonovanMaillard merged commit bd9a4b9 into PnX-SI:project-FLA_NS Dec 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Permettre de taguer les imports nécessitant des compléments/correctifs #253

Permettre de taguer les imports nécessitant des compléments/correctifs #253

mvergez commented Dec 20, 2021

mvergez commented Dec 21, 2021 •

edited

Loading

Permettre de taguer les imports nécessitant des compléments/correctifs #253

Permettre de taguer les imports nécessitant des compléments/correctifs #253

Conversation

mvergez commented Dec 20, 2021

mvergez commented Dec 21, 2021 • edited Loading

Ce qui a été fait

Backend/db :

Frontend :

Quelques captures (mon thème GeoNature est bleu)

mvergez commented Dec 21, 2021 •

edited

Loading