Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow to send notification (DB and/or email) when an import in synthe… #419

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

VincentCauchois
Copy link
Member

…sis is done.

Ref #414

@VincentCauchois VincentCauchois force-pushed the feat/send_notif_import_synthesis_done branch from 79e8f36 to 597535e Compare January 13, 2023 13:29
@bouttier bouttier force-pushed the feat/send_notif_import_synthesis_done branch 4 times, most recently from f7b6dd9 to d782329 Compare January 16, 2023 21:35
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 90.20% // Head: 90.24% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (d782329) compared to base (6ac1aa7).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head d782329 differs from pull request most recent head dff322b. Consider uploading reports for the commit dff322b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #419      +/-   ##
===========================================
+ Coverage    90.20%   90.24%   +0.03%     
===========================================
  Files           18       18              
  Lines         1542     1548       +6     
===========================================
+ Hits          1391     1397       +6     
  Misses         151      151              
Flag Coverage Δ
pytest 90.24% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/gn_module_import/tasks.py 90.24% <100.00%> (+0.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bouttier bouttier force-pushed the feat/send_notif_import_synthesis_done branch from d782329 to dff322b Compare January 16, 2023 21:43
@bouttier bouttier merged commit dff322b into develop Jan 16, 2023
@bouttier bouttier deleted the feat/send_notif_import_synthesis_done branch January 16, 2023 21:47
@VincentCauchois VincentCauchois self-assigned this Jun 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants