fix(import: checks) Improve check_altitudes and check_depths #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentCauchois
force-pushed
the
fix/import_check_altitudes
branch
3 times, most recently
from
1885bd4 to
0d3ce2f
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #445 +/- ##
========================================
Coverage 90.64% 90.64%
========================================
Files 18 18
Lines 1571 1571
========================================
Hits 1424 1424
Misses 147 147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
VincentCauchois
force-pushed
the
fix/import_check_altitudes
branch
from
0d3ce2f to
c89d90f
Compare
Signed-off-by: VincentCauchois <vincent.cauchois@mnhn.fr>
VincentCauchois
force-pushed
the
fix/import_check_altitudes
branch
from
c89d90f to
65d88ec
Compare
Signed-off-by: VincentCauchois <vincent.cauchois@mnhn.fr>
VincentCauchois
force-pushed
the
fix/import_check_altitudes
branch
from
4b9837a to
de8cdf5
Compare
VincentCauchois
changed the title
VincentCauchois
changed the title
bouttier
approved these changes
May 4, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_altitudesStill perform check_altitudes when altitudes are generated : update fields in
set_altitudes.Still perform "INVALID_INTEGER" error checks for "altitude_min" when "altitude_max" not in fields, and for "altitude_max" when "altitude_min" not in fields.
check_depthsStill perform "INVALID_INTEGER" error checks for "depth_min" when "depth_max" not in fields, and for "depth_max" when "depth_min" not in fields.