Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(import_report): display "Données importées" panel only when done #457

Merged

Conversation

VincentCauchois
Copy link
Member

Display panel "Données importées" only when import is "done", not when "in progress" or "in error".

How to test

  1. Create an import (which you know would work without errors) and stop before the end, to let in "in progress" : you may stop at step 2, right after clicking "Suivant" in step 1
  2. Go to see the report of this import, and observe that it is still in progress ("EN COURS" appearing on the top right), and that there are only three panels ; "Description de l'import", "Correspondances" and "Données invalides" ; but no panel "Données importées" visible (fixed by the present commit)
  3. Finalize the import : go until through all steps, until step 5, and launch the check (click on "Lancer la vérification") while asserting that a celery worker is running locally / then, after checks are done, confirm import of observations (click on "Importer vos N observations valides".
  4. Go to the report, and observe that the import is done ("TERMINE" on the top right) and that a 4th panel "Données importées" is now visible.

Display panel "Données importées" only when import is "done",
not when "in progress" or "in error".

Signed-off-by: VincentCauchois <vincent.cauchois@mnhn.fr>
@VincentCauchois VincentCauchois self-assigned this Jun 28, 2023
@VincentCauchois VincentCauchois added the invalid This doesn't seem right label Jun 28, 2023
@Pierre-Narcisi Pierre-Narcisi merged commit acfa1ea into hotfix2.1.0 Jun 29, 2023
@camillemonchicourt camillemonchicourt deleted the fix/condition-display-summary-import-report branch June 29, 2023 21:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants