Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

flagReplayComplete for wildcard subscribers, fix bad broker publish hang #433

Merged
merged 6 commits into from
Feb 7, 2025
Merged

flagReplayComplete for wildcard subscribers, fix bad broker publish hang #433

merged 6 commits into from
Feb 7, 2025

Conversation

NeejWeej
Copy link
Collaborator

@NeejWeej NeejWeej commented Jan 30, 2025 •
edited
Loading

This PR accomplishes the following:

  • Fix publisher hanging on invalid broker (it just kept trying to flush and timing out in its poll thread)
  • Fix wildcard (no key set) subscriptions, which were previously not calling flagReplayComplete UNTIL a message came in, so if no message came, it would hang

@NeejWeej
flagReplayComplete for wildcard subscribers, allow pulling csp timest…
a82030b 
…amp from Kafka message

Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej marked this pull request as ready for review January 30, 2025 07:35
@NeejWeej
Copy link
Collaborator Author

Addresses #414

@NeejWeej NeejWeej force-pushed the nk/fix_wildcard_subscriber_add_subscribe_from_msg_kafka branch from 799dee9 to 4510fc6 Compare January 30, 2025 10:19
@NeejWeej
Throw errors if topic or broker are invalid
61c792d 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej force-pushed the nk/fix_wildcard_subscriber_add_subscribe_from_msg_kafka branch from 4510fc6 to 61c792d Compare January 30, 2025 14:28
@NeejWeej
Small clean up
ae4dbb8 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej force-pushed the nk/fix_wildcard_subscriber_add_subscribe_from_msg_kafka branch from 0a1ca4d to 787740a Compare January 31, 2025 01:20
@NeejWeej
Dont do topic checking, too many caveats
79d9c3c 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej force-pushed the nk/fix_wildcard_subscriber_add_subscribe_from_msg_kafka branch from 787740a to 79d9c3c Compare January 31, 2025 01:35
@NeejWeej NeejWeej changed the title flagReplayComplete for wildcard subscribers, allow pulling csp times… flagReplayComplete for wildcard subscribers, fix bad broker publish hang Feb 7, 2025
@NeejWeej
Remove Kafka interface changes
0c67a53 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej force-pushed the nk/fix_wildcard_subscriber_add_subscribe_from_msg_kafka branch from 934ba4f to 0c67a53 Compare February 7, 2025 01:33
@NeejWeej
Style fix
90ecdcf 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej force-pushed the nk/fix_wildcard_subscriber_add_subscribe_from_msg_kafka branch from 078ab11 to 90ecdcf Compare February 7, 2025 18:04
@robambalu robambalu self-requested a review February 7, 2025 18:06
@NeejWeej NeejWeej merged commit 6cca482 into main Feb 7, 2025
29 checks passed
@NeejWeej NeejWeej deleted the nk/fix_wildcard_subscriber_add_subscribe_from_msg_kafka branch February 7, 2025 20:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@robambalu robambalu robambalu approved these changes

@AdamGlustein AdamGlustein Awaiting requested review from AdamGlustein AdamGlustein is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeejWeej @robambalu