PushPullInputAdapter replay mode #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
robambalu
commented
Feb 12, 2025
robambalu
commented
- renamed KafkaStartOffset enum to REplayMode and moved up so other push pull adapters can follow similar conventions
- PushPull will now always force ticks in sim mode with time < starttime to replay at starttime.
- Kafka adapter removed logic to drop ticks before starttime ( If user doesnt want data before starttime, they shouldnt be passing EARLIEST )
robambalu
requested review from
AdamGlustein,
svatasoiu and
alexddobkin
as code owners
robambalu
force-pushed
the
rba/startoffset_to_replay_mode
branch
4 times, most recently
from
645ff4e to
d9e1fe6
Compare
NeejWeej
previously approved these changes
Feb 12, 2025
- renamed KafkaStartOffset enum to REplayMode and moved up so other push pull adapters can follow similar conventions - PushPull will now always force ticks in sim mode with time < starttime to replay at starttime. - Kafka adapter removed logic to drop ticks before starttime ( If user doesnt want data before starttime, they shouldnt be passing EARLIEST ) Signed-off-by: Rob Ambalu <robert.ambalu@point72.com>
robambalu
force-pushed
the
rba/startoffset_to_replay_mode
branch
from
d9e1fe6 to
711428f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.