-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
In-part / non-unique names #40
Conversation
New issue: there are some cases where a genus and subgenus share a name, like Mus. julia> NCBITaxonomy.names_table[findall(isequal(10088), NCBITaxonomy.names_table.tax_id),:]
3×4 DataFrame
Row │ tax_id name unique_name class
│ Int64 String String? NCBIName…
─────┼────────────────────────────────────────────────────
1 │ 10088 mice mice <Mus> class_common_name
2 │ 10088 mouse mouse <Mus> class_common_name
3 │ 10088 Mus Mus <genus> class_scientific_name
julia> NCBITaxonomy.names_table[findall(isequal(862507), NCBITaxonomy.names_table.tax_id),:]
1×4 DataFrame
Row │ tax_id name unique_name class
│ Int64 String String? NCBIName…
─────┼───────────────────────────────────────────────────────
1 │ 862507 Mus Mus <subgenus> class_scientific_name This might require to add something like the |
Alternatively, we can drop a keyword argument to |
The best solution is probably to stick to the |
This closes #39 by erroring when there are multiple nodes with the same name, as in in-part names.