Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #533 sync data from veekun #676

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Fix #533 sync data from veekun #676

merged 1 commit into from
Dec 8, 2021

Conversation

Naramsim
Copy link
Member

@Naramsim Naramsim commented Dec 7, 2021

No description provided.

Copy link
Member

@C-Garza C-Garza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting back to Veekun for this will undo #648 and #649, which may not be entirely bad because I guess that's how the old versions of the game stored them like. This issue on Veekun describes a way on how to parse those flavor text entries.

@Naramsim
Copy link
Member Author

Naramsim commented Dec 8, 2021

Good catch @C-Garza, yes we can live with those reverts. At the end that's how they are stored in the Nintendo games.

@Naramsim Naramsim merged commit e0d6c0b into master Dec 8, 2021
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants