Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Gen 8 Pokedex Entries #8

Merged
merged 6 commits into from
Aug 30, 2020
Merged

Conversation

CMahk
Copy link

@CMahk CMahk commented Aug 26, 2020

I dumped my copies of each Pokemon title on the Switch and grabbed their respective dex entries (found at romfs/bin/message//common/zukan_comment_A or B) and ported pkNX's TextFile.cs to a python 3 script, read_swsh.py, that parses the data into a useable list. Then, to_csv.py turns the data into a CVS.

Sword and Shield keep both dex entry versions in their file system, so you only need one game to get both versions.
NOTE: You must dump the romfs from SwSh v1.2.0 or later to get the DLC dex entries.

Let's Go Pikachu / Eevee only use one dex entry version, so you only need one game.

HOW TO

To use the script, put each zukan_comment .dat and .tbl from each language and game into a folder with the script and rename each zukan_comment to the syntax as follows:

<language_id>_<swsh / lgpe>_comment.dat / .tbl

I put the language name at the end to differentiate which file contained what language, but the script doesn't need it.

Before
before

After
example

Finally, copy pokemon_species_flavor_text.csv into the folder, and run to_csv.py. An updated CSV will be created with the gen 8 entries.

This is what it should look like before you run to_csv.py.
script

Here is a zip with only the lgpe and swsh entries.

@Naramsim
Copy link
Member

Hi @CMahk, amazing work! Thanks a lot for this PR! I haven't tried by myself the scripts since I don't own any Switch nor LGEP or SHSW ROMs. Anyhow, I took a look at the files of this PR and the one you've attached and they are great! I really think that @magical and @veekun would be super interested as well to check out your files.

Before merging this PR I wanted to discuss a thing. You've set the new games correctly in the version_groups.csv, imho. But I think that in the version.csv file it would be better to specify that Let's go Eevee and Let's go Pikachu are different. Something along these lines:

31,19,lets-go-pikachu
32,19,lets-go-eevee
33,20,sword
34,20,shield

Would you be able to update the version.csv and also re-run your entire script so that the versions will be updated? (Otherwise, I can do it with a search-and-replace in VSCode)

Thanks!

@CMahk
Copy link
Author

CMahk commented Aug 28, 2020

Sure thing. I'll be available to fix it later tonight.

@Naramsim
Copy link
Member

Many thanks, @CMahk, I'm merging it and tomorrow I'll try to bring in the changes to PokeAPI/pokeapi.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants