Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create FormV2 and V2 Input components #102

Closed
joshuagraber opened this issue Sep 12, 2024 · 2 comments
Closed

Create FormV2 and V2 Input components #102

joshuagraber opened this issue Sep 12, 2024 · 2 comments

Comments

@joshuagraber
Copy link
Collaborator

joshuagraber commented Sep 12, 2024

Background

  • The form and input components have reached the limit of what can be accomplished with the schema architecture. It is time to refactor them.

Tasks

Create FormV2:

  • Copy shell of Form
  • Remove schema prop
  • Add defaultValues prop
  • Use provide to expose form values to children
  • Mark Form as deprecated. We will remove it and re-name FormV2 -> Form in a future story.

Create new versions of all Input... components

  • No need for the Input wrapper component. Move shared CSS to the global stylesheet under the @components directive.
  • Add slot for label content (to allow more complex UI than a simple string to be passed)
  • If no label slot passed, default to string passed as prop, which can now be optional (but add validation that either slot or prop is passed).
  • Same as above for the error UI.
@joshuagraber joshuagraber self-assigned this Sep 12, 2024
@joshuagraber joshuagraber changed the title Refactor Form and Input components Create FormV2 and V2 Input components Sep 12, 2024
joshuagraber added a commit that referenced this issue Oct 8, 2024
Create new form component that is more flexible in its rendering

fix #102
joshuagraber added a commit that referenced this issue Oct 8, 2024
build v2 input components to work with form v2

fix #102
Copy link

github-actions bot commented Oct 8, 2024

🎉 This issue has been resolved in version 3.1.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jan 2, 2025

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant