Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add record type icon to form input labels #103

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

joshuagraber
Copy link
Collaborator

Create RecordTypeIcon component and use in input labels

Background

  • Designs require this icon for some labels.
  • Because inputs are not yet flexible enough to accept this, we need to use this workaround

Description

  • Adds RecordTypeIcon
  • Uses RecordTypeIcon in form labels if label text matches a record type
  • (This is used for the SearchForm component in data-sources-v2.
  • I've also created an issue, Create FormV2 and V2 Input components #102 , to come back and resolve the underlying, which is that Form and Input are not flexible because they use a schema-based architecture.

Acceptance Criteria

  1. We'll test in ds-v2

@joshuagraber joshuagraber self-assigned this Sep 12, 2024
@joshuagraber joshuagraber merged commit 7ac0e6e into beta Sep 12, 2024
5 checks passed
@joshuagraber joshuagraber deleted the refactor/label-icon-for-record-types branch September 12, 2024 15:01
Copy link

🎉 This PR is included in version 3.1.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jan 2, 2025

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant