Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

v2: misc visual enhancements #123

Open
9 of 11 tasks
josh-chamberlain opened this issue Nov 20, 2024 · 0 comments · Fixed by #132
Open
9 of 11 tasks

v2: misc visual enhancements #123

josh-chamberlain opened this issue Nov 20, 2024 · 0 comments · Fixed by #132
Assignees

Comments

@josh-chamberlain
Copy link
Contributor

josh-chamberlain commented Nov 20, 2024

Context

We're close to launching v2, at least in alpha. It's time to start making small visual tweaks.

Requirements

most of these are actually changed in the pdap.io repo

  • don't expect a logo in the header
  • The inputs all have white bg and black text even in dark mode. Maybe we want the inputs properly themed as well
  • footer should sit above all elements, z-index-wise
  • where record categories are presented, the icon should come before the label
  • a tags have these border styles applied to them, making them take up more space than wanted in some situations. (fig 1)
    • fixed by applying border-none to a tags in "Jurisdiction level:" section
  • spacing tuned
    • design system: header, footer
    • pdap.io: search results, data source detail
  • colors tuned
    • many neutrals to goldneutral for interactive and wineneutral for static items throughout
  • hide requests from results (envars?)

Still todo

  • spacing parity on mobile
  • hover on agency rows is darker than expected, cannot seem to effect change
  • cannot get h1 h2 and other elements to render properly on the demo page in design-system, even when these render properly when used as a package.

fig 1:

Image
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant