refactor(components): miscellaneous form updates #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass attrs through to form element, pass event with data on emits, update test snapshot
joshuagraber
changed the title
| @@ -7,7 +7,7 @@ exports[`QuickSearchForm component > Renders a QuickSearchForm 1`] = ` | |||
| </p> | |||
| </div> | |||
| <div class="pdap-quick-search-form h-full max-h-[75-vh] justify-start p-0"> | |||
| <form class="pdap-form flex flex-wrap gap-x-4" id="quick-search-form" name="quickSearchForm"> | |||
| <form class="pdap-form flex flex-wrap gap-x-4 flex flex-wrap gap-x-4" id="quick-search-form" name="quickSearchForm"> | |||
There was a problem hiding this comment.
this isn't hurting anything, but maybe redundant? I would believe these are generated and applied to the form for some valid reason that would affect the snapshot, though.
There was a problem hiding this comment.
@josh-chamberlain No, that's important, actually, thank you for catching. It relates to v-bind merge behavior, and could cause problems in Form down the line. Making this update and one other.
josh-chamberlain
previously approved these changes
Aug 20, 2024
josh-chamberlain
previously approved these changes
Aug 20, 2024
Remove explicit attrs binding
include coverage for setValues
|
🎉 This PR is included in version 3.0.0-beta.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous updates to
FormBackground
Description
submitandchangeevents (changeis actually theinputevent on form input elements, but changing this would be breaking, so we'll wait)setValuesmethod onForm, allowing calling components to update the full values state programatically. (Useful for instance insearch-v2, where we may want to default toAll record typesbeing checked, but uncheck it any time another record type is checked, and vice versa.)Acceptance Criteria
localhost:8888. Ensure that everything still works