Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: update footer to v2 design #129

Merged
merged 5 commits into from
Dec 6, 2024
Merged

Conversation

joshuagraber
Copy link
Collaborator

Update footer

Background

  • The footer has been redesigned as a part of search v2

Description

  • Build new footer

Acceptance Criteria

  1. Run app.
  2. Navigate to any route.
  3. In src/demo/App.vue, update the values of the :fundraising-data prop to check different UI states.

@joshuagraber joshuagraber self-assigned this Dec 5, 2024
@josh-chamberlain
Copy link
Contributor

josh-chamberlain commented Dec 5, 2024

This looks very nice! How about below the 1024 breakpoint, making it no longer fixed and just sitting at the bottom like how it is now? Sorry, I was not very explicit about this.

@joshuagraber
Copy link
Collaborator Author

No worries, @josh-chamberlain that's updated!

@joshuagraber joshuagraber changed the title refactor: update footer refactor: update footer to v2 design Dec 6, 2024
@joshuagraber joshuagraber merged commit ee862e6 into beta Dec 6, 2024
5 checks passed
@joshuagraber joshuagraber deleted the feature/update-footer branch December 6, 2024 21:01
Copy link

github-actions bot commented Dec 6, 2024

🎉 This PR is included in version 3.1.0-beta.33 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jan 2, 2025

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants