Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update client data fetching and caching with tanstack query #198

Open
joshuagraber opened this issue Dec 23, 2024 · 1 comment
Open

Update client data fetching and caching with tanstack query #198

joshuagraber opened this issue Dec 23, 2024 · 1 comment
Assignees
Labels
enhancement feature request or other improvement Epic in progress

Comments

@joshuagraber
Copy link
Contributor

joshuagraber commented Dec 23, 2024

Context

Our client-side state has gotten complex enough in relationship with the server state that it now makes sense to add a proper querying and caching library.

Note: the current implementation is fine for the v2 launch, this is just something that is becoming necessary as the app gets more complex, so it's better to do it sooner than later.

Requirements

Tests

  • Current client tests should pass.

Docs

  • Remove references to pinia.
  • Add links to Tanstack docs.

Open questions

  • Evaluate whether Tanstack queries can be used with router loaders, or if we need to change that strategy. In some sense, trying to use loaders has turned out to be more headache than it's worth in our application.
    • Decision: we're going to remove the route loaders and use the queries directly.
@joshuagraber joshuagraber self-assigned this Dec 23, 2024
@joshuagraber joshuagraber transferred this issue from Police-Data-Accessibility-Project/data-sources-app Jan 11, 2025
@joshuagraber
Copy link
Contributor Author

Adding hold label to wait until everything from the migration is in main here.

@joshuagraber joshuagraber added in progress Epic enhancement feature request or other improvement and removed hold labels Feb 19, 2025
@joshuagraber joshuagraber changed the title Client data caching Update client data fetching and caching with tanstack query Feb 21, 2025
josh-chamberlain added a commit that referenced this issue Mar 5, 2025
…e/tanstack

feat: move data fetching to tanstack vue query (#198)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement feature request or other improvement Epic in progress
Projects
None yet
Development

No branches or pull requests

1 participant