Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

analyzer: merge property info from constructors #676

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Aug 29, 2018

Fixes #630.


This should handle merging of property information for situations like this:

class Foo {
  constructor() {
    /** @public some description */
    this.someProperty;
  }

  get someProperty() { return 1; }
}

we need to take the description from the constructor but everything else from the actual getter.

in terms of precedence, i take the property's info unless it is empty, then i try take the constructor's info.

@43081j 43081j force-pushed the property-merging branch 2 times, most recently from 4e2d82c to 4e392e1 Compare August 29, 2018 21:23
@usergenic usergenic merged commit a9b0507 into Polymer:master Jul 3, 2019
@43081j 43081j deleted the property-merging branch July 3, 2019 22:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[analyzer] Property defined in the mixin constructor does not have description and type definition
3 participants