-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Don't crash if alsa_snd_pcm_poll_descriptors fails #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will review the rest in more detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been discussed and approved by several people on the mail list.
I don't feel qualified to comment on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I faked an xrun in pa_linux_alsa.c at line 3645 with:
static int count = 0;
if( ret != self->nfds || ((count++ % 173) == 150)) // FIXME fake an error
Then I tried running the test paex_read_write_wire and it failed.
But the test aborts when it gets an xrun.
So I modified the test to just print a message when ReadStream or WriteStream return an error.
Now for every xrun I trigger in pa_alsa I get a flood of error returns.
Done |
Fixes #268 |
im still getting the error so i suspect my project is still using the old version. its a python project using the raspbian package python3-pyaudio. ive followed the installation recommendations for my device (https://github.com/PortAudio/portaudio/wiki/Platforms_RaspberryPi and http://portaudio.com/docs/v19-doxydocs/compile_linux.html), but i suspect theres another step? |
This fixes #268
This patch was original proposed by Chameleon here:
https://portaudio.music.columbia.narkive.com/3V9hsUak/pa-linux-alsa-c-3636-assertion-failed-with-hack-fix