Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: update gemini image_url parsing logic to support other mime type… #567

Merged
merged 3 commits into from
Aug 31, 2024
Merged

fix: update gemini image_url parsing logic to support other mime type… #567

merged 3 commits into from
Aug 31, 2024

Conversation

VisargD
Copy link
Collaborator

@VisargD VisargD commented Aug 31, 2024 •
edited
Loading

…s and gs urls

Title:

  • Brief Description of Changes

Description: (optional)

  • Dynamically pickup mimeType from b64 string and allow Google storage url
  • Detailed change 2

Motivation: (optional)

  • To allow different mimetypes and url in google vision calls.

Related Issues: (optional)

@VisargD VisargD merged commit 4c5f859 into main Aug 31, 2024
1 check passed
@VisargD VisargD deleted the fix/google-gemini-image-url-parsing branch September 13, 2024 07:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: google image_url parsing logic should support other mimeTypes and gs:// urls
1 participant
@VisargD