Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added request json as params to conditional routing #947

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

roh26it
Copy link
Collaborator

@roh26it roh26it commented Feb 18, 2025

Would open up model based conditional routing

@roh26it roh26it requested review from VisargD and narengogi February 18, 2025 19:26
@narengogi
Copy link
Collaborator

narengogi commented Feb 19, 2025

@roh26it also please setup a signing key and add it to GitHub, we have a policy that requires signed commits

https://docs.github.com/en/authentication/managing-commit-signature-verification

once you setup your key, you'd need to remove these commits and create a new commit, alternatively you could use another branch and cherrypick commits from here

to reset and commit again, so you can do

git reset --soft HEAD~n      # n is number of commits
git commit -m "signed commit"
git push --force             # force is required as you're removing commits from upstream

@roh26it roh26it force-pushed the feat/body-in-conditional-routing branch from 12390ab to 94169ec Compare February 21, 2025 11:40
@VisargD VisargD merged commit b58e4bb into main Feb 21, 2025
1 of 2 checks passed
@VisargD VisargD deleted the feat/body-in-conditional-routing branch February 21, 2025 13:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants