This repository was archived by the owner on Nov 4, 2021. It is now read-only.
make piscina useAtomics configurable #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clocking off now. Will revisit this next week. Probably best as a principle to not merge on a Friday evening. |
|
Let's get this in? @mariusandra Would help test what is a likely solution for #487 |
neilkakkar
approved these changes
Jun 28, 2021
|
yes, get it in! :D |
fuziontech
pushed a commit
to PostHog/posthog
that referenced
this pull request
Oct 12, 2021
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This allows us to test a potential solution to #487 more easily than having to tag a separate version of the plugin server. Useful for testing
useAtomics = falsein the playground and testk8s for example.Context in the issue.
Checklist