fix(action): Show the error info when deleting the action failed #27124
Conversation
xu20160924
changed the title
xu20160924
changed the title
|
@Twixes Could you please review my pull request? Thank you. |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
waiting |
There was a problem hiding this comment.
Thank you for the PR @xu20160924!
Just one thing I noticed: It looks like there's actually a few more analogous void deleteWithUndo(...) call sites – they should all be .catch()ing potential errors, so that app behavior is consistent. Can you update those places too?
xu20160924
force-pushed
the
fix-action-delete
branch
from
3432e79 to
7e4bc52
Compare
| }).catch((e) => { | ||
| lemonToast.error(`Failed to delete hog function: ${e.detail}`) | ||
| }) |
There was a problem hiding this comment.
Oh, thank you for going through all these! However, I wasn't clear enough, which I apologize about: We don't in fact want .catch() inside logics, since we have automatic error handling there.
This PR only needs to affect onClick handlers.
Can you quickly revert the changes to logic files? Then we'll be able to get this in immediately. :)
There was a problem hiding this comment.
Sorry for the incorrectly modified, I didn't notice the automatic error handling, I've reverted it.
xu20160924
force-pushed
the
fix-action-delete
branch
from
7e4bc52 to
f9580a8
Compare
Problem
Same delete API of the backend, but in the list missing shows the error information
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Handle the exceptions in the action list and display it.
Does this work well for both Cloud and self-hosted?
self-hosted worked
How did you test this code?
Self-hosted test