fix: Removing target options for survey resets its value to remove validation error

[lucasheriques]

Problem

Fixes #22186

When we add property targeting to a surveys and then remove it, we can't save the survey anymore.

Because there's a hidden form validation error hidden in the UI.

To fix it:

• When removing property targeting, remove it from the state as well
• Adds a trash icon next to the property, as suggested on the bug: Surveys: Can't remove user targeting options without setting rollout #22186. Then, if it's the last item, we actually remove the whole targeting from the survey

Changes

Old deleting behavior: https://www.loom.com/share/7e84a69cb97c4966970b2a796e375826

New behavior:

CleanShot.2024-12-23.at.15.24.05.mp4

Notice that now, after removing the property, there's no hidden form validation error.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

[github-actions]

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	1.11 MB

_{compressed-size-action}

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.