Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

config: introduce admin-server-host config parameter #3558

Merged
merged 14 commits into from
Jun 24, 2024
Merged

config: introduce admin-server-host config parameter #3558

merged 14 commits into from
Jun 24, 2024

Conversation

develop7
Copy link
Collaborator

Introduces optional admin-server-host config setting, which falls back to server-host value

@develop7 develop7 force-pushed the feat-add-admin-host branch from 03ae9dd to b24ae00 Compare May 29, 2024 15:44
@develop7 develop7 force-pushed the feat-add-admin-host branch from 4f520c4 to b491b64 Compare June 19, 2024 09:03
@develop7 develop7 marked this pull request as ready for review June 19, 2024 09:03
@develop7 develop7 changed the title Config: introduce admin-server-host config parameter config: introduce admin-server-host config parameter Jun 19, 2024
laurenceisla
laurenceisla reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@laurenceisla laurenceisla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new config should be tested in test/io/db_config.sql alongside the non-reloadable configs.

Also needs tests for the no-default configs (check below).

@develop7 develop7 requested a review from laurenceisla June 20, 2024 13:02
@laurenceisla laurenceisla force-pushed the feat-add-admin-host branch from 2e47348 to f466330 Compare June 21, 2024 02:29
@develop7 develop7 force-pushed the feat-add-admin-host branch from 0dceb38 to 243938d Compare June 21, 2024 16:38
laurenceisla
laurenceisla approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@laurenceisla laurenceisla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@laurenceisla laurenceisla merged commit 9d7e87b into PostgREST:main Jun 24, 2024
24 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther left review comments

@laurenceisla laurenceisla laurenceisla approved these changes

@steve-chavez steve-chavez steve-chavez approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@develop7 @steve-chavez @wolfgangwalther @laurenceisla