fix: clarify PGRST116 error message #3795
Conversation
Is this really a fix? I don't think so, nothing is broken. I wouldn't backport it. Imho it's just "changed". In conventional commits, this would still be a "feat", I think? Not sure. I guess I don't like strict conventional commits... |
Currently it's redundant and not easy to read.
```
{"message":"JSON object requested, multiple (or no) rows returned",
"details":"The result contains 2 rows"}
```
Now:
```
{"message":"Cannot coerce the result to a single JSON object",
"details":"The result contains an array of 0 objects"}
``
Also correct docs which had a wrong error code.
steve-chavez
force-pushed
the
pgrst116
branch
from
d667981 to
b4d28ef
Compare
|
Hm, I did a fix commit on da1150d, which was about changing messages too.
I do think it's a "fix" (fixes error message redundancy), but not so critical to backport it. Definitely not a feature though, I would want to keep those clearly differentiated in commits and CHANGELOG entries because they correlate to breaking changes sometimes. |
Yeah, not blocking from my side. I just started to think more about what kind of commit messages / prefixes we'd like to use - eventually, so that we could standardize on. |
Currently it's redundant.
{"message":"JSON object requested, multiple (or no) rows returned", "details":"The result contains 0 rows"}Now:
{"message":"Cannot coerce the result to a single JSON object", "details":"The result contains 0 rows"}Also correct docs which had a wrong error code.