Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

auth: prevent createReverse6 from generating illegal IDN record #14975

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

BozhanL
Copy link
Contributor

@BozhanL BozhanL commented Dec 16, 2024

Short description

createReverse6 will insert or push '0' to the converted address, so that dig will not treated it as an illegal IDN.
Closes #7524

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thank you. One very small nit.

docs/lua-records/functions.rst Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Dec 16, 2024

Pull Request Test Coverage Report for Build 12840316338

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 28 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.01%) to 64.707%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/lua-record.cc 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/misc.cc 2 63.15%
pdns/distributor.hh 2 51.86%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
modules/lmdbbackend/lmdbbackend.cc 2 73.66%
pdns/misc.hh 3 87.62%
pdns/packethandler.cc 3 72.79%
pdns/iputils.cc 3 56.84%
pdns/opensslsigners.cc 3 61.41%
pdns/rcpgenerator.cc 3 90.37%
pdns/signingpipe.cc 5 86.06%
Totals Coverage Status
Change from base Build 12832418127: 0.01%
Covered Lines: 127810
Relevant Lines: 166441

💛 - Coveralls

@Habbie Habbie merged commit abe6d42 into PowerDNS:master Jan 23, 2025
81 checks passed
@BozhanL BozhanL deleted the fix7524 branch January 23, 2025 10:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createReverse6() generating names that might be interpreted as illegal IDN names
4 participants