Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dnsdist: Remove TLSContext #15030

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

rgacogne
Copy link
Member

Short description

This PR removes the TLSContext class which is a duplicate of the more powerful TLSFrontend one, and rename showTLSContexts to showTLSFrontends to be consistent. This is a breaking change but 2.0.0 is the right time for that.

Closes #14616

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

This PR removes the `TLSContext` class which is a duplicate of the
more powerful `TLSFrontend` one, and rename `showTLSContexts` to
`showTLSFrontends` to be consistent.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12711216388

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 55 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.03%) to 64.956%

Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-lua.cc 1 49.45%
pdns/dnsdistdist/dnsdist.cc 2 68.85%
pdns/misc.hh 3 87.62%
pdns/misc.cc 3 64.51%
pdns/iputils.cc 3 55.76%
pdns/recursordist/rec-main.cc 3 62.38%
modules/godbcbackend/sodbc.cc 4 70.8%
pdns/recursordist/syncres.cc 5 80.08%
pdns/rcpgenerator.cc 5 90.55%
pdns/dnsdistdist/dnsdist-carbon.cc 6 61.6%
Totals Coverage Status
Change from base Build 12710659725: 0.03%
Covered Lines: 126276
Relevant Lines: 163687

💛 - Coveralls

Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@rgacogne rgacogne merged commit dc542d0 into PowerDNS:master Jan 16, 2025
81 checks passed
@rgacogne rgacogne deleted the ddist-remove-tlscontext branch January 16, 2025 08:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist: Ponder deprecating TLSContext lua API
3 participants